cmake: Fix output dir for Visual Studio generator#4121
Merged
Conversation
Member
|
Was on master...i reset to dev but now it's pulling in weird stuff. maybe recreate? |
…BUILD_CPP_TESTS is not set Signed-off-by: Leonardo Sarmiento <leonardo@moduleworks.com>
Contributor
Author
Sorry, I did not realize that. Now my patch is in dev. |
jimidle
pushed a commit
to jimidle/antlr4
that referenced
this pull request
Mar 28, 2023
…BUILD_CPP_TESTS is not set (antlr#4121) Signed-off-by: Leonardo Sarmiento <leonardo@moduleworks.com> Co-authored-by: Leonardo Sarmiento <leonardo@moduleworks.com> Signed-off-by: Jim.Idle <jimi@idle.ws>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix output dir for Visual Studio generator and for when ANTLR_BUILD_CPP_TESTS is not set
The antlr4 binaries are copied to
${ANTLR4_ROOT}/runtime/Cpp/distonly when ANTLR_BUILD_CPP_TESTS is set. However, when linking antlr4_shared to a new target, the target expects to find the. libbinary in${ANTLR4_ROOT}/runtime/Cpp/dist/$(Configuration)for Visual Studio generator and it expects${ANTLR4_ROOT}/runtime/Cpp/distfor other generator like Ninja. In any case, the binaries are always generated in${ANTLR4_ROOT}/runtime/Cpp/runtime/$(Configuration)or${ANTLR4_ROOT}/runtime/Cpp/runtimedepending on the generator.We can observe in this cmake file that the binaries are copied to
distonly when ANTLR_BUILD_CPP_TESTS is set.